build: update btcutil dependency #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it looks like there's a test failure related to the conn/addr manager. |
|
I wasn't able to reproduce locally, re-running the build. |
Roasbeef
approved these changes
Apr 1, 2021
| @@ -125,7 +125,7 @@ func newMemWallet(net *chaincfg.Params, harnessID uint32) (*memWallet, error) { | |||
|
|
|||
| // The first child key from the hd root is reserved as the coinbase | |||
| // generation address. | |||
| coinbaseChild, err := hdRoot.Child(0) | |||
| coinbaseChild, err := hdRoot.Derive(0) | |||
There was a problem hiding this comment.
Just wanted to note that this is fine since it's just an in-memory wallet, but otherwise we would've needed to use the "non standard" version.
Pull Request Test Coverage Report for Build 699640748
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently an issue for projects that depend on the latest version of
btcutiland use the btcd integration test harness.